Print stacktraces with error messages #2632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
previously requested changes
Sep 3, 2019
There was a problem hiding this comment.
Hum, so are you using :
- boost backtrace (libboost_stacktrace_addr2line, ...)
or - libbacktrace : https://github.com/ianlancetaylor/libbacktrace
?
* Prints the stacktrace with error messages. * Relies on boost::stacktrace * Adds the af_set_enable_stacktrace call to enable and disable stacktraces at runtime * Adds the AF_WITH_STACKTRACE CMake variable to enable and disable stacktraces at compile time
9prady9
reviewed
Jan 30, 2020
| CMP0074) | ||
| CMP0074 | ||
| CMP0077 | ||
| CMP0079) |
There was a problem hiding this comment.
I think this would throw error with CMake versions < 3.13.0
9prady9
reviewed
Jan 30, 2020
syurkevi
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stacktraces at runtime
stacktraces at compile time
Currently the error messages look like this:
With this PR and linking without libbacktrace.so the error messages will look like this:
With this PR and with libbacktrace.so the error messages look like this: