Skip to content

Fix buffer-overflow write in scan by key cuda kernel #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2019
Merged

Fix buffer-overflow write in scan by key cuda kernel #2693

merged 1 commit into from
Dec 20, 2019

Conversation

9prady9
Copy link
Member

@9prady9 9prady9 commented Dec 17, 2019

I did some code refactoring, please bare with that. The main fix is in scanbykey_first_bcast kernel during the final output write.

k < lim && id < out.dims[0] && id < boundary

Fixes #2680

@9prady9 9prady9 requested a review from umar456 December 17, 2019 16:58
@umar456 umar456 changed the title Fix buffer-overflow write in scan by kery cuda kernel Fix buffer-overflow write in scan by key cuda kernel Dec 19, 2019
@9prady9 9prady9 merged commit 7bfaeff into arrayfire:master Dec 20, 2019
@9prady9 9prady9 deleted the scanbykey_bugfix branch December 20, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umar456 umar456 umar456 approved these changes

Assignees
No one assigned
Labels
CUDA fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scanByKey / constructor / assignment operator bug
2 participants
@9prady9 @umar456