Skip to content

Fix unified segfault if no backends are found #2720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2020
Merged

Fix unified segfault if no backends are found #2720

merged 3 commits into from
Jan 15, 2020

Conversation

umar456
Copy link
Member

@umar456 umar456 commented Jan 14, 2020

Fix segfault in the unified backend caused by an infinite recursive call if no backends were found.

Refactored some error code logic.

@umar456 umar456 force-pushed the fix_unified_segfault branch from f16f05b to 7fdf8c5 Compare January 14, 2020 23:58
9prady9
9prady9 requested changes Jan 15, 2020
View reviewed changes
@umar456 umar456 force-pushed the fix_unified_segfault branch from 7fdf8c5 to 1f1d17c Compare January 15, 2020 05:51
@umar456 umar456 force-pushed the fix_unified_segfault branch from 1f1d17c to 7d6a94a Compare January 15, 2020 06:49
9prady9
9prady9 approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@umar456 umar456 merged commit 0acc75f into arrayfire:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9prady9 9prady9 9prady9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umar456 @9prady9