Fix build configs of mutli-config cmake generators #2736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c05086b to
09adfd2
Compare
umar456
previously approved these changes
Jan 31, 2020
4930230 to
f64f7c0
Compare
All upstream projects will use `Release` config on single config cmake generators if the value of CMAKE_BUILD_TYPE is either Release or RelWithDebInfo. In every other scenario, it will just use the existing value of CMAKE_BUILD_TYPE variable. Note: With current cmake min version as 3.5, which doesn't have ternary generator expression, setting the build type using generator expressions turned out to be too clumsy and cumbersone set of lines. Hence, used simple if-else code-block.
The default build type now is Release
f64f7c0 to
5f71ab9
Compare
umar456
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All upstream projects will use
Releaseconfig on single configcmake generators if the value of CMAKE_BUILD_TYPE is either Release
or RelWithDebInfo. In every other scenario, it will just use the
existing value of CMAKE_BUILD_TYPE variable.
Note: With current cmake min version as 3.5, which doesn't have ternary
generator expression, setting the build type using generator expressions
turned out to be too clumsy and cumbersone set of lines. Hence, used
simple if-else code-block.