Skip to content

Make the symbolManager a static pointer to avoid destruction on exit #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 19, 2020
Merged

Make the symbolManager a static pointer to avoid destruction on exit #2769

merged 2 commits into from
Feb 19, 2020

Conversation

umar456
Copy link
Member

@umar456 umar456 commented Feb 17, 2020

  • Avoid releasing symbol manager. Let OS release resources
  • Does not affect leak sanitizer
  • Use static instead of thread local to avoid loading the library
    multiple times

@umar456 umar456 mentioned this pull request Feb 17, 2020
Closed
@umar456 umar456 force-pushed the unified_static branch 2 times, most recently from 4cd6714 to a09959c Compare February 18, 2020 00:57
@umar456
Avoid errors when AF_BACKEND_DEFAULT passed to direct linked backend
e14780d
@umar456
Make the symbolManager a static pointer to avoid destruction on exit
0e6dde3 
* Avoid releasing symbol manager. Let OS release resources
* Does not affect leak sanitizer
* Use static instead of thread local to avoid loading the library
  multiple times
* Move activeBackend and activeHandle out of symbol manager since
  AFSymbolManager is a singleton class now. It didn't make sense
  to have those variables in there anyway because they do not do
  anything with the symbols. Added multi-threaded tests to make
  sure expected behavior when switching backends
9prady9
9prady9 reviewed Feb 18, 2020
View reviewed changes
@umar456 umar456 merged commit 70a8051 into arrayfire:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9prady9 9prady9 9prady9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umar456 @9prady9