Make cudnn dependency optional #2836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
requested changes
Apr 10, 2020
There was a problem hiding this comment.
Some style and code organization changes are needed.
I think it would it be beneficial if we just use the non cuDNN implementation as fallback when cuDNN isn't available at runtime.
We can just rename the convolveNN_base.cpp file as convolveNN_fallback.cpp and avoid the cmake changes (extra WITH_CUDNN definition and all cascading changes due to addition of WITH_CUDNN) completely.
Also, please fix the formatting too.
9prady9
approved these changes
Apr 13, 2020
umar456
added a commit
to umar456/arrayfire
that referenced
this pull request
Jun 27, 2020
* adds fallback for convolveNN functions * adds cudnn option, runtime fallback * Noexcept and const many Dependency module functions * Refactor cuDNN code in CMake * Fix fallback logic. refactor cuDNN util functions. Fix f16 wrap Co-authored-by: Umar Arshad <umar@arrayfire.com>
9prady9
pushed a commit
that referenced
this pull request
Jun 27, 2020
* adds fallback for convolveNN functions * adds cudnn option, runtime fallback * Noexcept and const many Dependency module functions * Refactor cuDNN code in CMake * Fix fallback logic. refactor cuDNN util functions. Fix f16 wrap Co-authored-by: Umar Arshad <umar@arrayfire.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need for an installed cuDNN library when building ArrayFire.
The new fallback methods match those in the opencl backend and determine the gradients through the wrap/unwrap methods.