Skip to content

Fix pinnedMemManager check. Fix MKL Sequential layer #2840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 14, 2020
Merged

Fix pinnedMemManager check. Fix MKL Sequential layer #2840

merged 2 commits into from
Apr 14, 2020

Conversation

umar456
Copy link
Member

@umar456 umar456 commented Apr 14, 2020

  • The setMemorymanagerPinned function was incorrectly checking the function pointer instead of the pinnedMemManager pointer.
  • MKL with the Sequential layer was broken because the ThreadingLibrary variable was required. The sequential layer does not have a threading library so MKL was set to not found because that variable was not set.

@umar456 umar456 added this to the 3.7.2 milestone Apr 14, 2020
9prady9
9prady9 requested changes Apr 14, 2020
View reviewed changes
@umar456 umar456 merged commit 9d268cd into arrayfire:master Apr 14, 2020
@umar456 umar456 deleted the mkl_sequential branch June 26, 2020 18:43
@umar456 umar456 mentioned this pull request Jun 27, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9prady9 9prady9 9prady9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@umar456 @9prady9