-
Notifications
You must be signed in to change notification settings - Fork 548
broadcasting in af_arith for binary operations #2871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
reviewed
May 14, 2020
9prady9
reviewed
May 14, 2020
9prady9
reviewed
May 14, 2020
umar456
reviewed
Apr 4, 2022
a945c6f
to
59bea35
Compare
As per the discussion during the maintainers meeting, support for matching vectors to corresponding matrix dimensions was dropped due to ambiguous cases with multiple matching dimensions. Instead, only the 1s wild-card style broadcasting will be supported:
|
umar456
requested changes
Jun 18, 2022
9320ad0
to
ef77042
Compare
umar456
requested changes
Jul 4, 2022
Co-authored-by: Umar Arshad <umar@arrayfire.com>
umar456
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will prepend 1s until dimension sizes match, then 1s are treated as wildcards and are broadcasted to their matching sizes.
In cases where one of the arguments is a vector, prepending until dimensions match may not align well:
Upon a mismatch, the prepended vectors will be shifted left until there is a match. In the above example the broadcast will be a success after a single additional shift.
This manner of treating vectors is a workaround due to no difference between.
TODO: