Use same Node class for all backends #2891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68664d0 to
00c6c3a
Compare
* Remove backend specific cpu::jit::Node and use common::Node as a base class for all backends. * Remove std::string for types in the node class in favor of the enum af::dtype. * Remove UnaryOp's default implementation
9prady9
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CPU backend was using a slightly modified version of the Node class. This PR modifies the CPU backend to use the same class as the other backends. This will allow us to move to LLVM based JIT in the future and provide a unified interface for all backends.
Additional clang-tidy changes. Removed several
using namespacestatements in the source. Reorganized the namespaces for several functions.Moved the Binary and Transform classes form
src/api/c/ops.hpptosrc/backend/common/[Binary,Transform].hpp.