Skip to content

Fix errors found with Address Sanitizer in the OpenCL backend #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 1, 2020
Merged

Fix errors found with Address Sanitizer in the OpenCL backend #2913

merged 7 commits into from
Jun 1, 2020

Conversation

umar456
Copy link
Member

@umar456 umar456 commented May 30, 2020 •
edited by 9prady9
Loading

  • Refactor Module and fix a leak of the cl::Kernel objects. These objects should be around for a while so the accumulated leak wasn't significant in most applications.
  • Fix leak in makeParam. This function was leaking the cl::Buffer object but not the cl_mem object so we were only leaking 8 bytes in the transpose function in a couple of operations in the magma code
  • Changed the free to delete because the object was allocated using a new call
  • Fixed a minor leak of the cl::Buffer object in susan, sparseArith, ireduce, and indexing. These were small leaks of only a few bytes.
  • Updated the LSAN Suppressions file to suppress intentional leaks in the clFFT library and internal buffers in libnvidia-opencl

@umar456 umar456 added the OpenCL label May 30, 2020
@umar456 umar456 added this to the 3.7.2 milestone May 30, 2020
@umar456 umar456 force-pushed the ocl_asan branch 3 times, most recently from 2bfb1e1 to 24412e6 Compare May 31, 2020 06:34
@9prady9 9prady9 added the fix label May 31, 2020
umar456 added 6 commits June 1, 2020 10:33
@umar456
Refactor Modules and Kernels. Fix leak in getKernel
1cd8478 
Refactor Module and fix a leak of the cl::Kernel objects. These objects should
be around for a while so the accumulated leak wasn't significant in most
applications.
@umar456
Fix mismatch new/delete calls in clfft
b285f3c
@umar456
Fix leak in susan
f3fccdb
@umar456
Fix leak in sparseArith
bf461ef
@umar456
Fix leak in OpenCL ireduce
9fa81a1
@umar456
Fix leak in OpenCL Indexing
f11c261
@umar456 umar456 merged commit bcdf0ba into arrayfire:master Jun 1, 2020
@umar456 umar456 deleted the ocl_asan branch June 26, 2020 18:36
@umar456 umar456 mentioned this pull request Jun 27, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9prady9 9prady9 9prady9 approved these changes

Assignees
No one assigned
Labels
fix OpenCL
Projects
None yet
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@umar456 @9prady9