Fix barrierOR fn in confidence connected opencl kernel #2969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the extra barrier sync towards end of barrierOR function after reading the reduction result, the caller's loop if any is going into infinite loop occasionally which is in turn randoms hangs. This doesn't seem to be an issue on non-nvidia hardware. Hence, we are conditionally adding the extra barrier sync conditionally for nvidia platform.
umar456
approved these changes
Jul 9, 2020
9prady9
added a commit
that referenced
this pull request
Aug 17, 2020
* Fix barrierOR fn in confidence connected opencl kernel Without the extra barrier sync towards end of barrierOR function after reading the reduction result, the caller's loop if any is going into infinite loop occasionally which is in turn randoms hangs. This doesn't seem to be an issue on non-nvidia hardware. Hence, we are conditionally adding the extra barrier sync conditionally for nvidia platform. * Add the hardware check comparison (cherry picked from commit 64855cb)
umar456
pushed a commit
that referenced
this pull request
Sep 9, 2020
* Fix barrierOR fn in confidence connected opencl kernel Without the extra barrier sync towards end of barrierOR function after reading the reduction result, the caller's loop if any is going into infinite loop occasionally which is in turn randoms hangs. This doesn't seem to be an issue on non-nvidia hardware. Hence, we are conditionally adding the extra barrier sync conditionally for nvidia platform. * Add the hardware check comparison (cherry picked from commit 64855cb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable confidence connected components function in OpenCL backend.
Changes to Users
The users can use confidence connected components in OpenCL backend from now on.
Checklist
[ ] Functions added to unified API[ ] Functions documented