Skip to content

Address perf regression in approx after dim based interop was introduced #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2020
Merged

Address perf regression in approx after dim based interop was introduced #2977

merged 2 commits into from
Aug 13, 2020

Conversation

9prady9
Copy link
Member

@9prady9 9prady9 commented Jul 21, 2020

Description

Fixes: #2975

Changes to Users

The performance of approx1 and approx2 should be back to what it was prior to 3.7.* releases.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

@9prady9 9prady9 added this to the 3.8.0 milestone Jul 21, 2020
@9prady9 9prady9 requested a review from umar456 July 21, 2020 14:23
@9prady9 9prady9 modified the milestones: 3.8.0, 3.7.3 Aug 7, 2020
@9prady9 9prady9 merged commit 8df8e6f into arrayfire:master Aug 13, 2020
@9prady9 9prady9 deleted the approx_perf_regression branch August 13, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umar456 umar456 umar456 approved these changes

Assignees
No one assigned
Labels
fix perf
Projects
None yet
Milestone
3.7.3
Development

Successfully merging this pull request may close these issues.

[Perf] Slow approx1 performance in v3.7.x
2 participants
@9prady9 @umar456