Skip to content

Add version info resource file for Window build #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

Add version info resource file for Window build #3025

merged 1 commit into from
Oct 30, 2020

Conversation

9prady9
Copy link
Member

@9prady9 9prady9 commented Oct 6, 2020

Description

Fixes: #3016

Changes to Users

None with respect to code development. It just adds some extra file info for dlls on Windows.

Checklist

  • Rebased on latest master
  • Code compiles
  • [ ] Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

@9prady9 9prady9 added this to the 3.8.0 milestone Oct 6, 2020
@9prady9 9prady9 requested a review from umar456 October 6, 2020 14:32
@9prady9
Copy link
Member Author

9prady9 commented Oct 7, 2020

Screenshot from 2020-10-07 23 51 22

@9prady9 9prady9 marked this pull request as ready for review October 7, 2020 18:21
@9prady9 9prady9 modified the milestones: 3.8.0, 3.8.1 Oct 26, 2020
@9prady9 9prady9 merged commit e9dcb69 into arrayfire:master Oct 30, 2020
@9prady9 9prady9 deleted the dll_ver_info branch October 30, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umar456 umar456 umar456 approved these changes

Assignees
No one assigned
Labels
build improvement
Projects
None yet
Milestone
3.8.1
Development

Successfully merging this pull request may close these issues.

DLLs from official installer are missing file version information on Windows
2 participants
@9prady9 @umar456