Skip to content

Fix lapack support check in CPU/OpenCL backend CMakeLists #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

9prady9
Copy link
Member

@9prady9 9prady9 commented Oct 19, 2020

Description

Prior to this change, if the build environment doesn't have non-MKL LAPACK libraries installed while Intel MKL is installed, then even when the user didn't turn ON using MKL due to the current check, LAPACK was enabled which resulted in build failure with missing headers/libraries.

Changes to Users

None to Application developers unless they are building ArrayFire themselves. In which case, they would now be able to build ArrayFire without linear algebra routines support in the above specified scenario.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

@9prady9 9prady9 added this to the 3.8.0 milestone Oct 19, 2020
@9prady9 9prady9 requested a review from umar456 October 19, 2020 04:35
@9prady9 9prady9 modified the milestones: 3.8.0, 3.8.1 Oct 26, 2020
@9prady9 9prady9 merged commit 56be928 into arrayfire:master Oct 30, 2020
@9prady9 9prady9 deleted the win_fixes branch October 30, 2020 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants