Use ArrayFire Stream for Thrust operations #3029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have tested in custom project, Thrust is no longer queueing on the default stream. Just for reference: there is still a bug in cusolver that is queueing the default stream during inverse(). |
syurkevi
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Thrust functions were being performed on the default stream. This PR fixes this to use the ArrayFire stream.
Description
ArrayFire had been using the default stream for Thrust operations. This was a mistake added when a Thrust policy was added to ArrayFire code to address temporary allocation by Thrust. This PR addresses that issue by using the ArrayFire stream for Thrust operations.
Changes to Users
N/Ajj
Checklist
[ ] Functions added to unified API[ ] Functions documented