Workaround for new cuSparse API introduced in CUDA patch release #3057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New API of cuSparse was introduced in 10.1.168 for Linux and the older 10.1.105 version doesn't it. Unfortunately, when the new API was introduced in ArrayFire's code base, I was testing against versions 10.1.168 or newer and hence didn't realize that this new API was introduced in a patch/fix release - unconventional. This change enables the new API only from 10.2.* on Linux since CUDA toolkit version variable set by CMake doesn't provide patch number.
umar456
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New API of cuSparse was introduced in 10.1.168 for Linux and the older
10.1.105 version doesn't it.
Unfortunately, when the new API was introduced in ArrayFire's code base,
I was testing against versions 10.1.168 or newer and hence didn't realize
that this new API was introduced in a patch/fix release - unconventional.
This change enables the new API only from 10.2.* on Linux since CUDA toolkit
version variable set by CMake doesn't provide patch number.
Changes to Users
Developers building ArrayFire's CUDA backend using toolkit version 10.1.105 will be able to build fine now.
Checklist
[ ] Tests pass[ ] Functions added to unified API[ ] Functions documented