Use short function name in non-debug builds in error messages #3060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, error message from an exception would look like below
In function af_err af_transpose_inplace(af_array, bool)
In file src/api/c/transpose.cpp:97
Earlier approach was hindering any useful log messages, especially from
runtime(like nvrtc) compilation phase, to be properly captured by
by the string returned by af_get_last_error function call.
Now it would look the same in debug builds but for release builds it
shall look like as following
In function af_transpose_inplace
In file src/api/c/transpose.cpp:97
umar456
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this, error message from an exception would look like below
Earlier approach was hindering any useful log messages, especially from
runtime(like nvrtc) compilation phase, to be properly captured by
by the string returned by af_get_last_error function call.
Now it would look the same in debug builds but for release builds it
shall look like as following
Fixes: #3053
Changes to Users
Issues such as the ones mentioned in #3053 will be fixed.
Checklist
[ ] Functions added to unified API[ ] Functions documented