Skip to content

Remove non-free guards for SIFT/GLOH algorithms #3071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

9prady9
Copy link
Member

@9prady9 9prady9 commented Dec 29, 2020

Description

SIFT patent expired recently and these algorithms can be provided as part of open source binaries that are distributed from our
website.

Fixes: #3007

Changes to Users

None to existing users. New users will be able to use sift/gloh functions from the installations done using our website binaries.

Checklist

  • Rebased on latest master
  • Code compiles
  • [ ] Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

@9prady9 9prady9 added this to the 3.8.1 milestone Dec 29, 2020
@9prady9 9prady9 requested a review from umar456 December 29, 2020 17:12
@9prady9 9prady9 force-pushed the free_sift branch 3 times, most recently from 6d853b5 to 6d73f23 Compare December 29, 2020 17:33
umar456
umar456 previously approved these changes Jan 11, 2021
@9prady9 9prady9 force-pushed the free_sift branch 3 times, most recently from a0b2d39 to 6bb51f2 Compare January 12, 2021 13:06
SIFT patent expired recently and these algorithms can be
provided as part of open source binaries that are distributed from our
website.
@9prady9 9prady9 force-pushed the free_sift branch 4 times, most recently from cd1d4dd to 7985cb0 Compare January 19, 2021 04:06
@9prady9 9prady9 merged commit 43b34a9 into arrayfire:master Jan 21, 2021
@9prady9 9prady9 deleted the free_sift branch January 21, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving SIFT to main repo
3 participants