Fix a infinite recursion bug in NaryNode JIT Node #3072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
commented
Dec 30, 2020
|
I think the clang-format error should be fixed once related fix from #3071 is merged. Locally I have made sure the formatting is good. |
52c1d46 to
3114ff8
Compare
When the maximum JIT tree height is one, createNaryNode goes into infinite recursion. This effects CUDA and OpenCL backends
5e96383 to
7ce4e6e
Compare
These functions are not exposed to users. They are not included when generating installers. These functions are purely for testing certain internal behavior given a certain combination of environment variables. Test for unit max JIT height infinite recursion bug
unmarked CUDA_VERSION as advanced so that users may see what CUDA toolkit is picked up
umar456
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the maximum JIT tree height is two, createNaryNode goes into
infinite recursion due to missing base case check inside the function.
Fixes: #3065
Changes to Users
Fixes the infinite recursion bug when maximum jit length is set to 2.
Checklist
[ ] Functions added to unified API[ ] Functions documented