Skip to content

Fix glad add_subdirectory to fix out of tree builds #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

umar456
Copy link
Member

@umar456 umar456 commented Mar 9, 2021

This was a problem on the arrayfire-benchmark repo where the repository
is built as a subproject

Description

Add the binary directory to the add_subdirectory command that adds the glad repository.
This was causing errors with the arrayfire-benchmark repository when building master.

Changes to Users

N/A

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

This was a problem on the arrayfire-benchmark repo where the repository
is built as a subproject
@umar456 umar456 requested a review from 9prady9 March 9, 2021 18:30
@syurkevi syurkevi self-requested a review March 10, 2021 00:56
@9prady9 9prady9 added this to the 3.8.1 milestone Mar 10, 2021
Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't change anything. I must have excluded the explicit binary directory since the glad target is an interface and doesn't get built directly.

@9prady9 9prady9 merged commit 799cba7 into arrayfire:master Mar 10, 2021
@9prady9 9prady9 deleted the glad_subdir branch March 10, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants