Skip to content

oneMKL related fixes and increase CLBLast dependency version #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2021

Conversation

9prady9
Copy link
Member

@9prady9 9prady9 commented May 10, 2021

Description

  • Fix Install commands when oneMKL is used
  • Bump up CLBlast dependency version to 1.5.2
  • Fix missing fftw include dir to MKL::RT imported target

Changes to Users

No code changes to users. These build improvements.

Checklist

  • Rebased on latest master
  • Code compiles
  • Tests pass
  • [ ] Functions added to unified API
  • [ ] Functions documented

9prady9 added 3 commits May 10, 2021 09:09
Intel MKL(not oneAPI oneMKL) didn't have soname files at all. All files
were simple so files. However, oneAPI introduced soname files and this
change takes into account that while collecting mkl dependencies for
arrayfire packaging.

When using old intel MKL, the resolution to REALPATH results in same
file and cmake doesn't complain if same file is copied twice. Not an
ideal scenario but that is fine for now.
@9prady9 9prady9 added the fix label May 10, 2021
@9prady9 9prady9 added this to the 3.8.1 milestone May 10, 2021
@9prady9 9prady9 requested a review from umar456 May 10, 2021 03:41
@9prady9
Copy link
Member Author

9prady9 commented May 10, 2021

cholesky_dense_opencl failure seems to be happening on Telsa T4 only as the moment.

@9prady9 9prady9 merged commit 0fe3332 into arrayfire:master May 10, 2021
@9prady9 9prady9 deleted the misc_fixes branch May 10, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants