The compare function should return false, for equal elements. #3141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
requested changes
Jun 21, 2021
There was a problem hiding this comment.
I think this should also be changed https://github.com/arrayfire/arrayfire/blob/master/test/sift.cpp#L49
Can you also please change the following as well
https://github.com/arrayfire/arrayfire/blob/master/test/orb.cpp#L48
https://github.com/arrayfire/arrayfire/blob/master/test/orb.cpp#L48
When compiling in debug mode, the MSVC compiler returns an non-compliance error.
|
@willyborn there is a merge commit in the PR commit history, please remove it. |
|
I found an extra one in topk |
9prady9
approved these changes
Jun 23, 2021
syurkevi
pushed a commit
that referenced
this pull request
Dec 28, 2021
* The compare function should return false, for equal elements. When compiling in debug mode, the MSVC compiler returns an non-compliance error. * compare functions should always return false when equal (cherry picked from commit 77181f1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling in debug mode, the MSVC compiler returns an non-compliance error.
The provided method should simulate the '<' function, not '<='.
Description
bug fix, could result in increase sort time or even incorrect results.
Changes to Users
None
Checklist