Use ONEAPI_ROOT env variable also for looking up MKL Installation #3150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the user sets-up MKL using Intel provided setup scripts prior to building ArrayFire, all environment variables are taken care of by the Intel setup scripts. This change addresses the scenario where oneAPI basetoolkit is installed but the setup script is not run before building ArrayFire.
With this additional environment variable based lookup, in the case MKL setup script is not run, ArrayFire CMake tries to locate MKL based on ONEAPI installation root. This change essentially enables easier look up of MKL installation for building ArrayFire using oneMKL. However, note that to run the built tests/examples the user needs to make sure oneMKL libraries are available via PATH or LD_LIBRARY_PATH for runtime programs to find them.
Changes to Users
None to library users. An minor ease of use enabler for ArrayFire developers.
Checklist
[ ] Tests pass[ ] Functions added to unified API[ ] Functions documented