Move death test into a separate serially executed unit test #3157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdfcbc7 to
bacfa19
Compare
Death tests are known to have issues when threads are involved. A better explanation is provided as part of google-test documentation at the below link. https://github.com/google/googletest/blob/master/docs/advanced.md#death-tests-and-threads
bacfa19 to
f274cd7
Compare
umar456
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Death tests are known to have issues when threads are involved. A better explanation is provided as part of google-test documentation at the below link.
https://github.com/google/googletest/blob/master/docs/advanced.md#death-tests-and-threads
Currently, array_cuda test is failing randomly on A100 test job. Here is the sample failure log https://ci.arrayfire.org/test/489455 This change is intended to fix this death-test/threads conflict.
Changes to Users
None
Checklist
[ ] Functions added to unified API[ ] Functions documented