Fix bug in getMappedPtr in OpenCL due to invalid lambda capture #3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug that was caused by an invalid capture of the Array class in the destructor of the mapped_ptr function. This caused intermittent errors when using the getMappedPtr function.
Fixes a bug in getMappedPtr where the Array object was not ready and needed to be evaluated when the map function was called. This appeared when the LHS or the RHS of the matmul function were JIT nodes and were sparse Arrays.
syurkevi
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug that was caused by an invalid capture of
the Array class in the destructor of the mapped_ptr function. This
caused intermittent errors when using the getMappedPtr function.
Description
This commit fixes a bug in the getMappedPtr function of the OpenCL
Array class. The bug was caused because we were capturing the
Array class using the
thispointer instead of specifically capturingthe Buffer_ptr object. These changes are necessary because the
clEnqueueUnmap function failed to execute for CPU backends and
causes segfaults in certain scenarios.
This PR can be backported to older versions.
Changes to Users
N/A
Checklist
[ ] Functions added to unified API[ ] Functions documented