Create ASSERT_IMAGE_NEAR which compares two images for equality #3170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an image comparison assertion to the tests that compares two images and if there is an error, uploads the result and the gold image to CDash for comparison. Useful for when image tests fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an image comparison assertion to the tests that compares two images
and if there is an error, uploads the result and the gold image to CDash
for comparison. Useful for when image tests fail
Description
ASSERT_IMAGE_NEAR will compare two images for similarity and upload
the image to ci.arrayfire.org if the test fails. This allows us to quickly view
the errors by going to the site and viewing the differences to determine the
error.
This assertion works on both af::array and af_array objects. It currently
supports f32, f64, u8, and b8 images but can support additional types
fairly easily.
Changes to Users
N/A
Checklist
[ ] Functions added to unified API