Restrict initializer list to fundamental types #3264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit limits the types that can be used in the initializer list to fundamental types. This change is necessary because when we use the uniform initialization syntax and pass in an array, the compiler incorrectly uses the initialization list constructor instead of the other array constructor.
17ef5aa to
5109060
Compare
syurkevi
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit limits the types that can be used in the initializer
list to fundamental types. This change is necessary because when
we use the uniform initialization syntax and pass in an array, the
compiler incorrectly uses the initialization list constructor instead
of the other array constructor.
Description
Previously the following code was not able to compile:
This was incorrectly using the initializer list syntax instead of the
af::array(af::array other)constructor.Changes to Users
Users can now use the universal syntax to initialize ArrayFire arrays
Checklist
[ ] Functions added to unified API[ ] Functions documented