Skip to content

Fix lapack test on OpenCL devices #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2017
Merged

Fix lapack test on OpenCL devices #114

merged 1 commit into from
Jan 17, 2017

Conversation

unbornchikken
Copy link
Member

In my desktop, the default device is an Intel/OpenCL stuff. The lapack test fails on that with the following error:

ERROR:root:Traceback (most recent call last):
  File "C:\git\arrayfire-python\arrayfire\tests\simple\_util.py", line 32, in run
    test(verbose)
  File "C:\git\arrayfire-python\arrayfire\tests\simple\lapack.py", line 42, in simple_lapack
    a = af.matmulTN(a, a) + 10 * af.identity(5,5)
  File "C:\git\arrayfire-python\arrayfire\blas.py", line 88, in matmulTN
    MATPROP.TRANS.value, MATPROP.NONE.value))
  File "C:\git\arrayfire-python\arrayfire\util.py", line 79, in safe_call
    raise RuntimeError(to_str(err_str))
RuntimeError: In function class std::shared_ptr<float> __cdecl opencl::Array<float>::getMappedPtr(void) const
In file src\backend\opencl\Array.hpp:260
OpenCL Error (-59): Invalid Operation when calling clEnqueueMapBuffer

It is obvious, because on lapack.py line 42 I found:

a = af.matmulTN(a, a) + 10 * af.identity(5,5)

Which leads to double OpenCL mapping of the same resource. I've fixed that line with an explicit copy, but I believe this situation should handled at core ArrayFire side. Maybe with a better error reporting, or with an implicit copy when this double map scenario happens. What do you think?

@pavanky
Copy link
Member

pavanky commented Jan 17, 2017

@unbornchikken Can you create a bug report on arrayfire for the same case and also include the OpenCL architecture you are using?

@pavanky pavanky merged commit 7465f50 into arrayfire:devel Jan 17, 2017
@unbornchikken unbornchikken mentioned this pull request Jan 18, 2017
Closed
@unbornchikken unbornchikken deleted the p2-fixed branch January 23, 2017 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unbornchikken @pavanky