Skip to content

build: improve cmake scripts #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 24, 2020
Merged

build: improve cmake scripts #59

merged 15 commits into from
Feb 24, 2020

Conversation

gocarlos
Copy link
Contributor

@gocarlos gocarlos commented Feb 24, 2020 •
edited
Loading

this modernizes the cmake scripts and also makes it possible to package as conan recipe using conan

problems solved:

  • installation of header files
  • make tests and examples optional
  • clean up compiler flags -> make it possible compile on mscv
  • make vendored json version optional -> important for software clearing in some corporations
  • added conan support and build instructions

@gocarlos gocarlos requested a review from arun11299 February 24, 2020 08:23
@gocarlos
Copy link
Contributor Author

@arun11299 it would be great if you could create a release after merging this

@gocarlos gocarlos mentioned this pull request Feb 24, 2020
Merged
4 tasks
@arun11299
Copy link
Owner

Wow..this is awsome. Thanks for the contribution!!
Since I am not well versed with the proposed changes, I will just merge it.

@arun11299 arun11299 merged commit 8a066c9 into arun11299:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arun11299 arun11299 Awaiting requested review from arun11299

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gocarlos @arun11299