Add --ignore-platform-reqs flag to Composer #26
Conversation
When using composer, the image may not have the required php extensions or modules to install successfully, so you have to manually pass the --ignore-platform-reqs flag each time. Adding this to the entry point of the image means that you can just run docker-compose run composer without additional flags. This avoids adding caveats to the documentation and adds to the "it just works" utility of docker.
|
@oranges13 Thanks for catching this, and good to know! |
|
This fails when running composer commands that don't support the |
|
I think this should be added by the user if they see the need to. The only time I ever use this flag is on Windows after I've installed horizon as it needs to be in every composer call thereafter. In fact I switched to a *nix based docker image solely to avoid having to use this flag by means of aliasing or throwing into my composer file as it can cause other issues as evidenced above. |
|
The composer docker container by default won't have any additional PHP extensions loaded though and may fail when your composer.json requires them ( gd is a good example ). Yes you could change the docker compose file to install composer on a *nix-based docker image, or copy the app image into a separate compare image but that kind of defeats the purpose that the repo author has designed. My opinion. That kind of goes beyond the scope of this repo to begin with, which is supposed to be a starting off point for most projects I believe. It is only really required for composer install /update though. Is there a different way to add that flag as a default for only those commands? Because otherwise it isn't necessarily obvious to everyone why it's failing especially people who maybe new to docker. |
When using composer, the image may not have the required php extensions or modules to install successfully, so you have to manually pass the --ignore-platform-reqs flag each time.
Adding this to the entry point of the image means that you can just run
docker-compose run composerwithout additional flags.This avoids adding caveats to the documentation and adds to the "it just works" utility of docker.