Skip to content

Remove deprecated <licenseUrl /> element #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2022
Merged

Remove deprecated <licenseUrl /> element #315

merged 2 commits into from
Mar 30, 2022

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Mar 30, 2022

  • also, don't need to ignore NU5125 anymore

@dougbu
Remove deprecated <licenseUrl /> element
b1aaeb2 
- also, don't need to ignore NU5125 anymore
@dougbu
Copy link
Contributor Author

dougbu commented Mar 30, 2022

Any other reviewers I should be adding when changing this repo @mkArtakMSFT❔

@dougbu
!fixup! Remove <requireLicenseAcceptance/>
45ffb3e 
- can't require a license w/o `<license/>` or `<licenseUrl/>`
@dougbu
Copy link
Contributor Author

dougbu commented Mar 30, 2022

Trying another TeamCity test build… Will merge if that works 😀

@dougbu dougbu merged commit 362b7be into release/3.2.8 Mar 30, 2022
@dougbu dougbu deleted the dougbu/embed.files.314 branch March 30, 2022 21:02
@renovate renovate bot mentioned this pull request Apr 24, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkArtakMSFT mkArtakMSFT Awaiting requested review from mkArtakMSFT

1 more reviewer

@TanayParikh TanayParikh TanayParikh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dougbu @TanayParikh