Fix multiline support for github format #366
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue (#355 (comment))
In the
tabulate
library, thegithub
format did not properly handle multiline text.If you passed tabulate data cells containing multiline text and used the
maxcolwidths
parameter to truncate text, the result was incorrect because thegithub
format was not included in the list of formats that support multiline text processing.Solution
The issue was that the
github
format was not added to themultiline_formats
dictionary, which defines the formats that support multiline text.The solution was simple: just add
"github": "github"
to this dictionary.After our fix, the
github
format now correctly processes multiline text, just like other supported formats such asfancy_outline
.