Skip to content

adding in unsafe html format #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2020
Merged

adding in unsafe html format #42

merged 3 commits into from
Apr 7, 2020

Conversation

danja100
Copy link
Contributor

@danja100 danja100 commented Mar 5, 2020

This is in case a user requires unescaped html format within their table.

@astanin
Copy link
Owner

astanin commented Apr 6, 2020 •
edited
Loading

There are complaints about the latest changes to the 'html' format, because it didn't escape before.

I intend to revert changes to 'html' and keep its output raw unescaped, and instead introduce a separate 'safehtml' format. Would you like to update your pull requests that way? -- never mind

@astanin astanin merged commit a610a4d into astanin:master Apr 7, 2020
@westurner westurner mentioned this pull request Apr 21, 2020
Closed
2 tasks
@westurner
Copy link
Contributor

westurner commented Apr 21, 2020 •
edited
Loading

FWIW, checking every value for an __html__ method and escaping it if it doesn't have one yet is the way that MarkupSafe (which Jinja2 uses for autoescaping) handles optionally unescaped input.

That would be more granular than not escaping anything in the table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdhityaG AdhityaG AdhityaG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danja100 @astanin @westurner @AdhityaG