Skip to content

fix: use the tracing crate with its original package name. #1728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mythrnr
Copy link
Contributor

@mythrnr mythrnr commented Jun 19, 2025

Pull Request Overview

This pull request updates the use of the tracing crate to align with recent changes in its upstream release, removing the use of the tracinglib alias.

Changes

  • Updates Cargo.toml to refer to the tracing crate directly, instead of using the tracinglib alias.
  • Adjusts the "tracing" feature declaration to use dep:tracing for clarity and alignment with Cargo best practices.
  • Updates import paths in relevant modules (dataloader, extensions::tracing) to use the standard tracing crate directly.

Reasons for Changes

  • The update accommodates breaking changes in the tracing-attributes crate, which made the alias approach no longer viable.

@mythrnr mythrnr marked this pull request as ready for review June 19, 2025 16:44
Copy link

@n-puzankov-supra n-puzankov-supra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested this fork in our project and it seems to be working good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants