Skip to content

fix: repeatable Directive Output in SDL Generation #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kay-schecker
Copy link

Summary

This PR corrects the SDL (Schema Definition Language) output for directives that are marked as repeatable.

Details

  • Ensures that the keyword repeatable is correctly included in the directive SDL representation when is_repeatable is set to true.
  • The output now conforms to the GraphQL specification for repeatable directives.

Additions

  • Added unit tests to verify correct SDL rendering:
    • test_repeatable_directive_dsl
    • test_non_repeatable_directive_dsl

Motivation

Previously, the SDL output omitted the repeatable keyword even when the directive was defined as repeatable. This led to incorrect or incomplete schema definitions. With this fix, the SDL generation is now accurate and spec-compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant