Define 'tick' #141
Merged
Define 'tick' #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
reviewed
Jan 14, 2017
| * | ||
| * One iteration of the loop is called one "tick". A tick covers the following steps: | ||
| * | ||
| * 1. Activate watchers created / enabled in the last tick / before `run`. |
There was a problem hiding this comment.
With `run` you are referencing the method? Please suffix () then to make this more obvious.
bwoebi
reviewed
Jan 14, 2017
| * 1. Activate watchers created / enabled in the last tick / before `run`. | ||
| * 2. Execute all enabled defer watchers. | ||
| * 3. Execute all due timers, each timer only once per tick. | ||
| * 4. Execute actionable stream watchers, each only once per tick. |
There was a problem hiding this comment.
Uh, there is no order guarantee between timers and stream watchers. Merge these two into a single step.
There was a problem hiding this comment.
Fixed, once per tick should be fine?
bwoebi
approved these changes
Jan 20, 2017
trowski
requested changes
Jan 22, 2017
| * | ||
| * 1. Activate watchers created / enabled in the last tick / before `run()`. | ||
| * 2. Execute all enabled defer watchers. | ||
| * 3. Execute all due timer and actionable stream callbacks, each only once per tick. |
There was a problem hiding this comment.
Can signals be executed at any time or should they be included in this step? All current implementations execute pending signals only in this step, but should that be part of the spec?
trowski
approved these changes
Jan 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.