Remove setFactory() side-effect and add resetDriver() #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did you remove the nullability? |
|
@kelunik The nullability seemed pointless… why would you explicitly remove the factory without setting another? |
|
Because tests or whatever. |
|
Testing maybe… so I'll put it back. |
|
Closing, as project discontinued for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoking
Loop::setFactory()removes the activeDriverinstance as a side-effect. This PR removes this side-effect and requires a newDriverFactoryinstance be passed toLoop::setFactory()(instead of being nullable).To remove the current
Driverinstance and force a new one to be created, aLoop::resetDriver()method is added. This method cannot be invoked while the loop is running.