Skip to content

Fix possible name collision in attribute output #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

Fix possible name collision in attribute output #20

merged 1 commit into from
Jan 20, 2021

Conversation

goto-bus-stop
Copy link
Contributor

If another test or bench proc macro is in scope, the #[test] in
the output may not refer to Rust's own #[test] macro, but some other
macro.

@goto-bus-stop
Fix possible name collision in attribute output
2b01133 
If another `test` or `bench` proc macro is in scope, the `#[test]` in
the output may not refer to Rust's own `#[test]` macro, but some other
macro.
yoshuawuyts
yoshuawuyts approved these changes Jan 20, 2021
View reviewed changes
Copy link
Collaborator

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is great; thanks heaps!

@yoshuawuyts yoshuawuyts merged commit fbf6ecd into async-rs:master Jan 20, 2021
@yoshuawuyts
Copy link
Collaborator

Published a new release which includes this fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goto-bus-stop @yoshuawuyts