Skip to content

Implement I/O-safe traits on types #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 1, 2023
Merged

Implement I/O-safe traits on types #1036

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7c408f1
add I/O safe traits
notgull Aug 11, 2022
e1d66f5
code review
notgull Aug 16, 2022
c63c433
add end-of-file newline
notgull Aug 16, 2022
27f26ea
iline docs
notgull Aug 16, 2022
dc7bb8e
Fix minor issues
notgull Apr 30, 2023
c177103
Update src/fs/file.rs
notgull May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
code review
  • Loading branch information
@notgull
notgull committed Apr 30, 2023
commit e1d66f53a2a0e05da27c4417f85b371d2a9070df
10 changes: 4 additions & 6 deletions src/fs/file.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ use crate::prelude::*;
use crate::task::{spawn_blocking, Context, Poll, Waker};
use crate::utils::Context as _;

const ARC_TRY_UNWRAP_EXPECT: &str = "cannot acquire ownership of the file handle after drop";

/// An open file on the filesystem.
///
/// Depending on what options the file was opened with, this type can be used for reading and/or
Expand Down Expand Up @@ -413,9 +415,7 @@ impl From<std::fs::File> for File {
}

cfg_unix! {
use crate::os::unix::io::{AsRawFd, FromRawFd, IntoRawFd, RawFd};


use crate::os::unix::io::{AsRawFd, FromRawFd, IntoRawFd, RawFd};

impl AsRawFd for File {
fn as_raw_fd(&self) -> RawFd {
Expand Down Expand Up @@ -1027,6 +1027,4 @@ mod tests {
Ok(())
})
}
}

const ARC_TRY_UNWRAP_EXPECT: &str = "cannot acquire ownership of the file handle after drop";
}