feat: implement sync::Barrier #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
reviewed
Sep 25, 2019
Based on the implementation in tokio-rs/tokio#1571
36af98a to
b77b72d
Compare
yoshuawuyts
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
This patch looks good to me. I think we should accept this, and I'll file a follow-up PR to mark this as "unstable". The reason for that is that we're currently pulling in quite a few deps, and Stjepan hasn't had a chance to review the API here either (though I think we're okay).
To reduce the amount of deps we have to build I've also filed a patch against Broadcaster: leo60228/broadcaster#1.
Either way; this is fantastic work, thanks so much for putting the time in to build this!
|
It looks like it's Cargo that's failing CI on MacOS. All other tests' pass, so I think this should be fine. Let's see if Bors accepts this. bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 26, 2019
240: feat: implement sync::Barrier r=yoshuawuyts a=dignifiedquire ~~Based on the implementation in tokio-rs/tokio#1571 Based on the implementation in the std lib Things to discuss - `async` or `std` `Arc` in examples and tests - ~~`async` or `std` `Mutex` in the implementation~~ can't use std, as it needs to be shared - use of `broadcaster` dependency to implement, well broadcast To fix - [x] missing debug implementation, once broadcaster has it, or it is dropped ## Docs  Co-authored-by: dignifiedquire <dignifiedquire@users.noreply.github.com>
Build failed
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 26, 2019
240: feat: implement sync::Barrier r=yoshuawuyts a=dignifiedquire ~~Based on the implementation in tokio-rs/tokio#1571 Based on the implementation in the std lib Things to discuss - `async` or `std` `Arc` in examples and tests - ~~`async` or `std` `Mutex` in the implementation~~ can't use std, as it needs to be shared - use of `broadcaster` dependency to implement, well broadcast To fix - [x] missing debug implementation, once broadcaster has it, or it is dropped ## Docs  Co-authored-by: dignifiedquire <dignifiedquire@users.noreply.github.com>
Build failed
|
|
Looks like on this nightly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the implementation in tokio-rs/tokio#1571Based on the implementation in the std lib
Things to discuss
asyncorstdArcin examples and testsasyncorstdMutexin the implementationbroadcasterdependency to implement, well broadcastTo fix
Docs