Skip to content

Add Write::write_fmt #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2019
Merged

Add Write::write_fmt #311

merged 5 commits into from
Oct 13, 2019

Conversation

yoshuawuyts
Copy link
Contributor

Implements Write::write_fmt. Ref #245. Ref #131.

Also added write and writeln macros to the root as re-exports from std because they work out of the box!

Figured this would be good enough, and we don't need to implement fmt (closes #247). Thanks!

@yoshuawuyts
init write_fmt
58c3a06 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Oct 12, 2019
@yoshuawuyts
cleanup
570dedd 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts force-pushed the missing-write-methods branch 2 times, most recently from 4f055ee to f3eba1f Compare October 12, 2019 23:34
@yoshuawuyts
comments
f3eba1f 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts
cargo fmt
a1cd76e 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts changed the title init write_fmt Add Write::write_fmt Oct 13, 2019
@yoshuawuyts
update desc
b62e4a1 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
@yoshuawuyts yoshuawuyts mentioned this pull request Oct 13, 2019
Merged
dignifiedquire
dignifiedquire approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@yoshuawuyts yoshuawuyts merged commit 33da049 into master Oct 13, 2019
@yoshuawuyts yoshuawuyts deleted the missing-write-methods branch October 13, 2019 17:53
@yoshuawuyts yoshuawuyts added this to the 0.99.10 milestone Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.99.10
Development

Successfully merging this pull request may close these issues.

[tracking] fmt
2 participants
@yoshuawuyts @dignifiedquire