Add context to more errors #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18cbf4a to
e01f07d
Compare
yoshuawuyts
requested changes
Nov 25, 2019
There was a problem hiding this comment.
This is really good work!
Left a few commends regarding capitalization. Std doesn't capitalize errors, so probably neither should we (and at the very least we should be consistent).
Also left a few comments where it'd be nice to know which addresses we couldn't resolve. Unsure if we can retrieve that information, but if we can that'd be 💯.
Thanks so much; looking forward to this patch!
Co-Authored-By: Yoshua Wuyts <yoshuawuyts+github@gmail.com>
71e626a to
94791c8
Compare
Moves the point of adding error context to the net::addr module so that we have access to the raw address input and can include it in the error message.
94791c8 to
56538eb
Compare
yoshuawuyts
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty mechanical additions and by no means exhaustive: I bascially just wanted to cover the APIs I end up using quite often :)
For a future PR it might be interesting to add a test that shows that our errors include the correct sources, and that they might even work well with std backtraces.
cc #569