Skip to content

feat: implement Barrier using Condvar #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2020
Merged

feat: implement Barrier using Condvar #581

merged 2 commits into from
May 7, 2020

Conversation

tmccombs
Copy link
Contributor

This depends on #369 and fixes #565

@yoshuawuyts yoshuawuyts mentioned this pull request Dec 17, 2019
Closed
@dignifiedquire
Copy link
Member

@tmccombs what is the state of this, why is this only a draft?

@tmccombs
Copy link
Contributor Author

tmccombs commented Jan 3, 2020

Mostly because it is dependent on an open pull request.

@dignifiedquire
Copy link
Member

@tmccombs I think you should be able to finish this, now that #369 is merged

@tmccombs tmccombs marked this pull request as ready for review April 27, 2020 05:09
@dignifiedquire dignifiedquire changed the title Barrier feat: implement Barrier using Condvar May 7, 2020
@dignifiedquire dignifiedquire merged commit 6f6fced into async-rs:master May 7, 2020
@dignifiedquire
Copy link
Member

thank you @tmccombs

@dignifiedquire dignifiedquire mentioned this pull request May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite Barrier using WakerSet
2 participants
@tmccombs @dignifiedquire