Skip to content

link to our contribution guidelines #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2019
Merged

link to our contribution guidelines #587

merged 1 commit into from
Nov 27, 2019

Conversation

yoshuawuyts
Copy link
Contributor

This links to our contribution guidelines. We should set this up for a CoC and Security policy as well. Thanks!

@yoshuawuyts yoshuawuyts force-pushed the contributing branch 2 times, most recently from 55c53fa to e66e2e2 Compare November 26, 2019 10:40
@yoshuawuyts
link to our contribution guidelines
e66e2e2 
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
k-nasa
k-nasa approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@k-nasa k-nasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
but, I dont know it realy necessary.
async.rs/contribute link is writen on README.

@yoshuawuyts
Copy link
Contributor Author

@k-nasa the main appeal for including this is that it'll show in the sidebar whenever someone creates a new issue or PR. Same goes for CoC and security policy.

@yoshuawuyts yoshuawuyts merged commit 63f7ea3 into master Nov 27, 2019
@yoshuawuyts yoshuawuyts deleted the contributing branch November 27, 2019 12:21
@k-nasa
Copy link
Member

k-nasa commented Nov 27, 2019

Thanks.
I understand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-nasa k-nasa k-nasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshuawuyts @k-nasa