Skip to content

feat: initial implementation of std::process #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

feat: initial implementation of std::process #723

wants to merge 4 commits into from

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Mar 9, 2020 •
edited
Loading

Outstanding work

If anyone is interested in helping to bring this over the line that would be great, just let me know.

Example

use async_std::process::Command;

let output = Command::new("echo")
                      .arg("Hello world")
                      .output()
                      .await
                      .expect("Failed to execute command");

assert_eq!(b"Hello world\n", output.stdout.as_slice());

Implements #22

@dignifiedquire dignifiedquire mentioned this pull request Mar 9, 2020
Open
@skade
Copy link
Collaborator

skade commented Mar 9, 2020

Implementation details are built based on https://github.com/alexcrichton/tokio-process

Note that this means we should at some point document the original authorship and credit to Alex Crichton and Ivan Petkov: https://github.com/alexcrichton/tokio-process/blob/master/Cargo.toml#L8

@dignifiedquire
Copy link
Member Author

Note that this means we should at some point document the original authorship and credit to Alex Crichton and Ivan Petkov: alexcrichton/tokio-process:Cargo.toml@master#L8

Agreed, any thoughts on how to best do that?

@skade
Copy link
Collaborator

skade commented Mar 9, 2020

Either on a comment in the main module or an addendum to our LICENSE file. We could also add a section in our in-project documentation.

@fenhl
Copy link
Contributor

fenhl commented May 14, 2020

Has there been a decision on forgetting vs killing the process on drop? I see that the documentation implies kill on drop but references Child::forget which does not exist, so I'm wondering how accurate that is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dignifiedquire @skade @fenhl