Skip to content

Implementing from_fn #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implementing from_fn #7

wants to merge 2 commits into from

Conversation

justin1dennison
Copy link

I have started working on the from_fn free function. However, I may need a little guidance in the implementation. I tried to smoke test the function, but was not able to get the smoke test to ever complete.

Thegaram
Thegaram reviewed Mar 23, 2020
View reviewed changes
src/from_fn.rs Outdated
// let mut output = vec![];

// let mut stream = crate::from_fn(|| async move {
// Some(1u8)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your f must return None eventually, otherwise it will not terminate. See the example here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Thegaram. I don't know what I was thinking.

@justin1dennison justin1dennison changed the title [WIP] Implementing from_fn Implementing from_fn Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Thegaram Thegaram Thegaram left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin1dennison @Thegaram