Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General TRO spectral scatterer #886

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

riclarsson
Copy link
Contributor

This adds the most generic TRO spectral scatterer to Scattering Species. It is must be fully implemented by the user. I also add it as a test to the existing simple-test case to show that it is possible to fully pass python functions to it

@riclarsson
Copy link
Contributor Author

@simonpf This branch shows what I was talking about during the meeting.

The new files contain the structs for more limited return types I was after, and also the full implementation of the general scatterer for tro spectral.

It also wraps the visiting functions in scattering_species.cc in a way that you don't have to implement all of the interface for every type. E.g., a type that cannot be TRO does not need the TRO interfaces.

@riclarsson
Copy link
Contributor Author

Had to make the mutex change as part of this branch because there was a kernel panic somewhere (only in CI, I cannot see it locally, so it might be a very narrow problem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant