Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

fix lambda parsing issues #246 #253

Merged
merged 1 commit into from
Apr 24, 2018
Merged

fix lambda parsing issues #246 #253

merged 1 commit into from
Apr 24, 2018

Conversation

falcondai
Copy link
Contributor

@falcondai falcondai commented Apr 19, 2018 •
edited
Loading

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Capture lambda with \b(lambda)\s?+

Alternate Designs

Benefits

Resolve #246

Possible Drawbacks

Applicable Issues

#246

@maxbrunsfeld
Copy link
Contributor

Thanks!

@maxbrunsfeld maxbrunsfeld merged commit 239d7cd into atom:master Apr 24, 2018
@falcondai
Copy link
Contributor Author

falcondai commented Apr 24, 2018 •
edited
Loading

@maxbrunsfeld I overlooked one issue with my proposed changes and it causes an issue when parsing lambda_not (due to the new whitespace match). Added another test case and a better regex for lambda. Submitting a PR

@falcondai falcondai mentioned this pull request Apr 24, 2018
Merged
@kbrose

This comment has been minimized.

Sign in to view
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lambda: does not highlight lambda as a keyword
3 participants
@falcondai @maxbrunsfeld @kbrose