[SDK-3212] Remove impl package export in module-info #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We are removing the option where library users can use our implementations. This will ensure we will be able to change the internal working much easier and avoid unwanted dependencies on customer end. Though we have to remember that projects that doesn't use module system will still be able to access our
implpackageWe have also removed the comment which says to remove transitive for Jackson. We should not use 'remove transitive' since that will expose the Jackson library through ours. The current use of Jackson library is correct. This StackOverflow answer explains it better - https://stackoverflow.com/a/46504020
Testing
We created a new project and tested the library as a dependency with module-info removed. This was tested in Java 8 (which doesn't have module support), Java 11 with modules and Java 11 without modules