Skip to content

[SDK-3154] Improved Exception Handling #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 29, 2022
Merged

[SDK-3154] Improved Exception Handling #568

merged 4 commits into from
Mar 29, 2022

Conversation

poovamraj
Copy link
Contributor

Changes

  • Added 2 new subclasses to InvalidClaimException to improve the behaviour and not break existing functionality at the same time (MissingClaimException, IncorrectClaimException)
  • Relevant Documentations are updated
  • Assertions refactored to have respective Exceptions
  • Added CustomMatchers to test member variables of the Exceptions

References

Existing PR on this topic - #498

Testing

All assertions now also test whether the respective member variables are present

  • This change adds test coverage
  • This change has been tested on the latest version of Java or why not

@poovamraj poovamraj added this to the v4-Beta milestone Mar 28, 2022
@poovamraj poovamraj requested a review from a team as a code owner March 28, 2022 08:01
@poovamraj poovamraj requested a review from panga March 28, 2022 08:20
@poovamraj poovamraj mentioned this pull request Mar 28, 2022
Closed
panga
panga approved these changes Mar 28, 2022
View reviewed changes
Copy link

@panga panga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This implementation is nice addition to the developer experience.

@poovamraj poovamraj merged commit 67df3d4 into v4-dev Mar 29, 2022
@poovamraj poovamraj modified the milestones: v4-Beta, 4.0.0-beta.0 May 6, 2022
@poovamraj poovamraj mentioned this pull request May 6, 2022
Merged
@evansims evansims deleted the invalid-claim-exception-improvements branch July 5, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panga panga panga approved these changes

Assignees
No one assigned
Labels
CH: Added review:large Large review
Projects
None yet
Milestone
4.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
2 participants
@poovamraj @panga